nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨

Home Page:https://nodejs.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

test_runner: do not read from `process.argv` and `process.cwd()` in run()

mcollina opened this issue · comments

Currently the codebase for

function run(options = kEmptyObject) {
accesses some poperties of process, capturing some options there. However, we also expose run() to the end users, therefore we should capture all this information in
const options = {
and pass it down to run() as options.

@mcollina this issue still relevant or are you already working on it ? I ask it because I see you mentioned it on your last PR !
If it's still relevant, I'll start working on it :)

It's likely best to wait until my PR lands first!

Okay, I'll wait :)

@eliphazb go ahead and make the PR!

Okay 🚀 I'm going

@mcollina someone already take it :(