nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨

Home Page:https://nodejs.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[discuss] Move `lint-js-fix` to `lint-js --fix` + `lint-md --fix`

RedYetiDev opened this issue · comments

What is the problem this feature will solve?

Right now, to resolve the linting issues in Node.js JavaScript files, users need to execute make lint-js-fix. I find this confusing because the error message from make lint-js indicates:

  X errors and X warnings could potentially be fixed with the `--fix` option.

What is the feature you are proposing to solve the problem?

I propose the removal of lint-js-fix and the addition of lint-js --fix, for consistency with eslint's output.

Additionally, while it is being changed, a lint-md --fix command might not hurt, as the linter supports a --fix argument.

  • If implemented, I'd like to work on this.

What alternatives have you considered?

No response

What is there to discuss? If someone sends a PR that makes it possible to do make lint-js --fix, it would likely get accepted. If someone makes a PR that removes make lint-js-fix, it would likely get rejected.

Sure, I'll send a PR to allow lint-js --fix . I wanted to discuss so I didn't work on something that wouldn't be helpful to add

I mean, obviously folks will have different opinion on whether something is helpful or not (I for one am perfectly happy with the current lint-js-fix target, and will probably keep using it), so discussing this would not be productive. If you're willing to spend time on it, no one can stop you – except maybe if it turns out to be technically unfeasible / would require some unacceptable tradeoff elsewhere.

I've just learned that there is no way AFAICT to achieve this, but I'll send a Pr for MD lint fix