Review state of canary in CI
targos opened this issue · comments
- I fixed the linter issue on
canary-base. test-repl-issues are nodejs/node#43676- V8 CI issue is #236
test-vm-break-on-sigintis new and unclear (timeout)- #227 is still a problem
Some nightly release builds are red too: https://ci-release.nodejs.org/job/iojs+release/8644/
Some new compiler errors:
fedora (seems to be a missing include, I commented on the V8 CL):
12:55:47 ../deps/v8/src/wasm/module-compiler.cc: In member function ‘v8::internal::wasm::{anonymous}::CompilationUnitQueues::Queue* v8::internal::wasm::{anonymous}::CompilationUnitQueues::GetQueueForTask(int)’:
12:55:50 ../deps/v8/src/wasm/module-compiler.cc:147:10: error: ‘unique_lock’ is not a member of ‘std’
12:55:50 147 | std::unique_lock<std::shared_mutex> queues_guard{queues_mutex_};
12:55:50 | ^~~~~~~~~~~
12:55:50 ../deps/v8/src/wasm/module-compiler.cc:36:1: note: ‘std::unique_lock’ is defined in header ‘<mutex>’; did you forget to ‘#include <mutex>’?
12:55:50 35 | #include "src/wasm/wasm-serialization.h"
12:55:50 +++ |+#include <mutex>
12:55:50 36 |
12:55:50 ../deps/v8/src/wasm/module-compiler.cc:147:39: error: expected primary-expression before ‘>’ token
12:55:50 147 | std::unique_lock<std::shared_mutex> queues_guard{queues_mutex_};
12:55:50 | ^
12:55:50 ../deps/v8/src/wasm/module-compiler.cc:147:41: error: ‘queues_guard’ was not declared in this scope
12:55:50 147 | std::unique_lock<std::shared_mutex> queues_guard{queues_mutex_};
12:55:50 | ^~~~~~~~~~~~
12:55:50 make[2]: *** [tools/v8_gypfiles/v8_base_without_compiler.target.mk:1047: /home/iojs/build/workspace/node-test-commit-linux/out/Release/obj.target/v8_base_without_compiler/deps/v8/src/wasm/module-compiler.o] Error 1
smartos:
64/out/Release/obj.target/v8_libbase/deps/v8/src/base/platform/platform-solaris.o.d.raw -c
11:46:29 In file included from ../deps/v8/src/base/free_deleter.h:15,
11:46:30 from ../deps/v8/src/base/debug/stack_trace_posix.cc:41:
11:46:30 ../deps/v8/src/base/platform/memory.h: In function 'std::size_t v8::base::MallocUsableSize(void*)':
11:46:30 ../deps/v8/src/base/platform/memory.h:118:10: error: 'malloc_usable_size' was not declared in this scope; did you mean 'MallocUsableSize'?
11:46:30 118 | return malloc_usable_size(ptr);
11:46:30 | ^~~~~~~~~~~~~~~~~~
11:46:30 | MallocUsableSize
11:46:30 make[2]: *** [tools/v8_gypfiles/v8_libbase.target.mk:177: /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/v8_libbase/deps/v8/src/base/debug/stack_trace_posix.o] Error 1
11:46:30 make[2]: *** Waiting for unfinished jobs....
/cc @nodejs/platform-smartos ^
Build failure on AIX:
https://ci.nodejs.org/job/node-test-commit-aix/43725/nodes=aix72-ppc64/console
13:19:30 g++ -pthread -Wl,-bbigtoc -maix64 -Wl,-blibpath:/usr/lib:/lib:/opt/freeware/lib/pthread/ppc64 -maix64 -Wl,-bbigtoc -o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/mksnapshot /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/embedded-empty.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/embedded-file-writer.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-aix.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-base.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-generic.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-mac.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-win.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/mksnapshot.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/snapshot-empty.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/v8_gypfiles/libv8_init.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/v8_gypfiles/libv8_libbase.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/v8_gypfiles/libv8_libplatform.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/icu/libicui18n.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/icu/libicuucx.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/icu/libicudata.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/v8_gypfiles/libv8_zlib.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/v8_gypfiles/libv8_compiler.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/v8_gypfiles/libv8_initializers.a -ldl -lrt
13:19:40 ld: 0711-317 ERROR: Undefined symbol: TLS init function for v8::internal::g_current_isolate_
13:19:46 ld: 0711-317 ERROR: Undefined symbol: .TLS init function for v8::internal::g_current_isolate_
13:19:47 ld: 0711-345 Use the -bloadmap or -bnoquiet option to obtain more information.
13:19:47 collect2: error: ld returned 8 exit status
13:19:47 gmake[2]: *** [tools/v8_gypfiles/mksnapshot.target.mk:224: /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/mksnapshot] Error 1
@nodejs/platform-aix
This is related to a linker issue with extern thread_local - patch to v8 main branch to fix this: https://chromium-review.googlesource.com/c/v8/v8/+/4031867/2
Edit: Better solution for this is to add -fno-extern-tls-init flag (used by v8 ninja build) to Node gyp build; Node main branch PR: nodejs/node#45496