Port absl config to gyp

Question

Port absl config to gyp

targos opened this issue 3 years ago · comments

https://github.com/nodejs/node-v8/actions/runs/1256415634

In file included from ../deps/v8/src/base/platform/mutex.h:10,
                 from ../deps/v8/src/base/platform/condition-variable.h:10,
                 from ../deps/v8/src/libplatform/default-foreground-task-runner.h:13,
                 from ../deps/v8/src/libplatform/default-foreground-task-runner.cc:5:
../deps/v8/src/base/optional.h:8:10: fatal error: absl/types/optional.h: No such file or directory
    8 | #include "absl/types/optional.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Michaël Zasso · Answer 1 · Wed Sep 22 2021 03:33:24 GMT+0800 (China Standard Time)

This is an external dep to V8 that we'll have to pull.
Main BUILD.gn: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+/refs/heads/main/BUILD.gn

I probably won't have time to work on this in the near future.

Michaël Zasso · Answer 2 · Wed Sep 22 2021 03:34:17 GMT+0800 (China Standard Time)

I disabled the canary update GitHub action. It won't work until this is done.

Richard Lau · Answer 3 · Wed Sep 22 2021 06:12:02 GMT+0800 (China Standard Time)

Is this likely to block V8 9.5 for Node.js 17?

Michaël Zasso · Answer 4 · Wed Sep 22 2021 12:52:13 GMT+0800 (China Standard Time)

No, this is blocking V8 9.6

Richard Lau · Answer 5 · Fri Sep 24 2021 22:29:32 GMT+0800 (China Standard Time)

I've opened node-core-utils PR to add abseil to the fetched V8 dependencies on V8 updates: nodejs/node-core-utils#565

Richard Lau · Answer 6 · Sat Sep 25 2021 02:02:12 GMT+0800 (China Standard Time)

https://github.com/nodejs/node-v8/actions/runs/1256415634

In file included from ../deps/v8/src/base/platform/mutex.h:10,
                 from ../deps/v8/src/base/platform/condition-variable.h:10,
                 from ../deps/v8/src/libplatform/default-foreground-task-runner.h:13,
                 from ../deps/v8/src/libplatform/default-foreground-task-runner.cc:5:
../deps/v8/src/base/optional.h:8:10: fatal error: absl/types/optional.h: No such file or directory
    8 | #include "absl/types/optional.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

FWIW this particular use was reverted in v8/v8@d67f060

Michaël Zasso · Answer 7 · Sat Sep 25 2021 16:04:19 GMT+0800 (China Standard Time)

https://github.com/nodejs/node-v8/actions/runs/1256415634

In file included from ../deps/v8/src/base/platform/mutex.h:10,
                 from ../deps/v8/src/base/platform/condition-variable.h:10,
                 from ../deps/v8/src/libplatform/default-foreground-task-runner.h:13,
                 from ../deps/v8/src/libplatform/default-foreground-task-runner.cc:5:
../deps/v8/src/base/optional.h:8:10: fatal error: absl/types/optional.h: No such file or directory
    8 | #include "absl/types/optional.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

FWIW this particular use was reverted in v8/v8@d67f060

Right. It re-enabled the job as it seems V8 doesn't use absl anywhere after this revert.

Michaël Zasso · Answer 8 · Mon Jul 18 2022 21:41:14 GMT+0800 (China Standard Time)

Closing as this didn't show up again after almost a year.