error C2373: '__pfnDliNotifyHook2': redefinition;

Question

error C2373: '__pfnDliNotifyHook2': redefinition;

zetsin opened this issue 8 years ago · comments

ERR

 win_delay_load_hook.c
C:\Users\zetsin\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\src\win_delay_load_hook.c(34): error C2373:
'__pfnDliNotifyHook2': redefinition; different type modifiers [D:\GitHub\node-winode\node_modules\ref\build\binding.vcx
proj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\delayimp.h(134): note: see declaration of '__pfnDliNot
  ifyHook2'

WHILE

npm install ref

ENV

Microsoft Windows [Version 10.0.10240]
(c) 2015 Microsoft Corporation. All rights reserved.

>node -v
v4.4.7
>npm -v
3.10.2
>node-gyp -v
v3.4.0
>python -V
Python 2.7.12
>msbuild /ver
14.0.25420.1

Anna Henningsen · Answer 1 · Fri Jul 01 2016 16:28:13 GMT+0800 (China Standard Time)

npm -g install npm@next?

Jinquan Liu · Answer 2 · Fri Jul 01 2016 17:05:43 GMT+0800 (China Standard Time)

Thanks a lot, @addaleax 👍

Something wrong happened:

"...\npm\node_modules\npm\node_modules\node-gyp\src\win_delay_load_hook.cc':** No such file or directory

after npm -g install npm@next

So I did that:

cd "...\npm\node_modules\npm\
npm install

It works, finally

Anna Henningsen · Answer 3 · Fri Jul 01 2016 17:22:44 GMT+0800 (China Standard Time)

Something wrong happened:

That does not look like something that should happen. Do you still have the npm-debug.log from that installation attempt?

Jinquan Liu · Answer 4 · Fri Jul 01 2016 18:56:22 GMT+0800 (China Standard Time)

Let me do it again.

rd/s/q "...\npm\node_modules\npm"
npm -g install npm@next
cd "...\npm\node_modules\npm\node_modules\node-gyp"
dir

I found that there is no "src" folder in "node-gyp", so the wrong happened when i use node-gyp build(e.g. npm install ref)

"...\npm\node_modules\npm\node_modules\node-gyp\src\win_delay_load_hook.cc':** No such file or directory

Ben Noordhuis · Answer 5 · Fri Jul 01 2016 19:39:56 GMT+0800 (China Standard Time)

cd "...\npm\node_modules\npm\node_modules\node_gyp"

Is that a typo? The directory is called 'node-gyp', not 'node_gyp'.

Jinquan Liu · Answer 6 · Fri Jul 01 2016 19:59:39 GMT+0800 (China Standard Time)

Yeah, its a typo I have edited, i'm so sorry. @bnoordhuis

Ben Noordhuis · Answer 7 · Fri Jul 01 2016 20:12:25 GMT+0800 (China Standard Time)

No problem. Just to be sure, can you delete your node_modules directory and install npm@next again?

If you still can't build ref, can you post the full build log of npm install ref?

Juha Rantanen · Answer 8 · Fri Jul 01 2016 20:33:50 GMT+0800 (China Standard Time)

I found a workaround, go to AppData\Roaming\npm\node_modules\npm and type npm remove node-gyp then npm install node-gyp.

I think this is due to using npm-windows-upgrade. It guides to use --production flag so I guess it installs npm with --production too. So node-gyp was missing src/.

First I had a problem that the upgrade was installing npm@3.10.3 and it had the previous node-gyp. I posted a comment about it. So I had node-gyp@3.4.0 in my global node_modules but 3.3.1 inside npm.

Anyway, now I'm finally able to build. :)

Rod Vagg · Answer 9 · Tue Jul 05 2016 18:58:23 GMT+0800 (China Standard Time)

fwiw npm@next is probably not going to fix this, yet, there was a problem in the upgrade that went out with 3.10.4, see npm/npm#13256 (my fault somehow I believe). It's been fixed in tree and I imagine it'll be out soon in a 3.10.5. npm@2 works fine though if you're able to use v2.

André Jonas · Answer 10 · Wed Jul 06 2016 18:29:18 GMT+0800 (China Standard Time)

@rvagg I think I may have the same issue with npm 2.14.12. I have pretty much the same environment as @zetsingithub, except for the npm version. I was trying to install mariasql and got:

win_delay_load_hook.c
C:\Users\Andre\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\src\w
in_delay_load_hook.c(31): error C2373: '__pfnDliNotifyHook2': redefinition; dif
ferent type modifiers [D:\Projects\betarena_chat\node_modules\mariasql\build\de
ps\libmariadbclient\mysys_ssl\mysys_ssl.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\delayimp.h(134
  ): note: see declaration of '__pfnDliNotifyHook2'

Do you know if this issue might affect npm@2 as well?

Rod Vagg · Answer 11 · Thu Jul 07 2016 19:43:55 GMT+0800 (China Standard Time)

yep, you need 2.15.9: https://github.com/npm/npm/releases/tag/v2.15.9
I think npm i npm@2 -g should be enough to upgrade you, we don't carry it in our Node LTS releases yet but it'll get there.

Vasanthrajan · Answer 12 · Sat Jul 09 2016 13:25:17 GMT+0800 (China Standard Time)

@rvagg That did the trick, Thank you!

swadical · Answer 13 · Mon Jul 11 2016 16:26:39 GMT+0800 (China Standard Time)

Had the same issue, npm -g install npm@next fixed it for me, if anyone else is in the same boat.

Daniel Thompson · Answer 14 · Tue Jul 12 2016 00:09:30 GMT+0800 (China Standard Time)

npm -g install npm@next appears to be the magic sauce. Thanks for posting that!

Kai Burjack · Answer 15 · Tue Jul 12 2016 01:31:35 GMT+0800 (China Standard Time)

Same here. I tried to install the oracledb module and got the same redefinition; different type modifiers for __pfnDliNotifyHook2 error.
Doing a npm -g install npm@next did fix this issue.

Rod Vagg · Answer 16 · Tue Jul 12 2016 13:16:43 GMT+0800 (China Standard Time)

npm -g install npm@latest should do the trick now that it's been pushed out in a stable release, no need to jump forward to next which can sometimes contain regressions.

Jack Billström · Answer 17 · Mon Aug 29 2016 00:42:24 GMT+0800 (China Standard Time)

Hade the exact problem when trying to install node module "bcrypt". Installed it without any errors now, cheers!

konyee · Answer 18 · Thu Sep 01 2016 23:01:30 GMT+0800 (China Standard Time)

I had same problem with "os-service", but I have a solution also.
npm install os-service --force && cd node_modules\os-service && node-gyp configure && node-gyp rebuild

redrockzee · Answer 19 · Thu Sep 29 2016 00:10:22 GMT+0800 (China Standard Time)

I had a lot of trouble getting this working for Oracle drive...same error with node-gyp. These are the prerequisites. I think this will also work for other versions of Visual Studio but I used the lastest Community edition 2015.

You must have at least 3.10.8 version of NPM. This is critical.
npm -g install npm@next

Make sure Node globally uses the same version 2015
npm config set msvs_version 2015 --global

Delete node_modules directory in your project
npm install

JasonS · Answer 20 · Fri Oct 07 2016 11:03:46 GMT+0800 (China Standard Time)

if you are working on an old version like I was, a simple npm install -g npm (without the @next) worked.

chrismark · Answer 21 · Wed Nov 02 2016 18:29:49 GMT+0800 (China Standard Time)

npm -g install npm@next worked. Thanks.

Olivier Combe · Answer 22 · Fri Nov 04 2016 00:45:45 GMT+0800 (China Standard Time)

For me npm i -g npm@next didn't work, but the trick from @RanzQ to reinstall node-gyp worked ! Thanks a lot this was driving me crazy

Khaidi Chu · Answer 23 · Wed Jan 18 2017 19:07:30 GMT+0800 (China Standard Time)

What shall I do if I don't want to use next? Because I hate flatten dependencies.

Anna Henningsen · Answer 24 · Wed Jan 18 2017 19:09:30 GMT+0800 (China Standard Time)

@XadillaX It’s been a while since you had to use npm@next to resolve this; just upgrade your npm or node to the latest version and you should be fine.

Jean Robert · Answer 25 · Tue Apr 25 2017 23:32:47 GMT+0800 (China Standard Time)

just to note that npm install -g npm@next broke my npm x.x
so i uninstalled node and installed again, tried it all again and the npm got broken again. Any command i try to execute, even only "npm" just causes a lot of errors like "cannot find npmlog module".

Need to say that i'm using nvm to install and use node 5.3.0 as my old project needs. And the first issue i had was installing node-oracledb. This project worked months ago, and it still works in my macosx but in windows i'm with these errors.

Will try to install node 5.3.0 and use just npm install -g npm as @jasonswearingen suggested

Dane Springmeyer · Answer 26 · Wed May 31 2017 05:27:12 GMT+0800 (China Standard Time)

note: most of the workarounds here recommend upgrading node-gyp by upgrading npm, which is fine. But in some cases users may instead wish to upgrade just node-gyp, which also fixes this issue (since the underlying bug was fixed in #952).

Jacob · Answer 27 · Thu Jun 22 2017 03:20:29 GMT+0800 (China Standard Time)

@springmeyer I am using node-gyp v3.6.2 and still having this problem (node v6.11.0 and npm v3.10.10). Does that release contain the fix you mentioned?

Dane Springmeyer · Answer 28 · Thu Jun 22 2017 04:34:42 GMT+0800 (China Standard Time)

Yes @jacobq - as far as I can tell the fix landed in v3.3.3: #956. Perhaps you have an older version being invoked without realizing it?

Jacob · Answer 29 · Thu Jun 22 2017 23:45:08 GMT+0800 (China Standard Time)

(Edited)
@springmeyer Whoa, I think you're right, but I have no idea why this is happening. Any ideas how it might get stuck at an old version? For example, is it possible for another module to list it in package.json or something?

The error is happening in node_modules\npm\node_modules\node-gyp\src\win_delay_load_hook.c on the line

PfnDliHook __pfnDliNotifyHook2 = load_exe_hook;

which was fixed/changed in node-gyp in f31482e in June 2016, and I think it was part of the fix you mentioned. Trying to see where this file was coming from I went up a few levels to node_modules\npm\node_modules\node-gyp\package.json and found this:

{
  "_args": [
    [
      "node-gyp@~3.2.1",
      "/Users/ogd/Documents/projects/npm/npm"
    ]
  ],
  "_from": "node-gyp@>=3.2.1 <3.3.0",
  "_id": "node-gyp@3.2.1",
  "_inCache": true,
  "_installable": true,
  "_location": "/npm/node-gyp",
  "_nodeVersion": "6.0.0-pre",
  "_npmUser": {
    "email": "info@bnoordhuis.nl",
    "name": "bnoordhuis"
  },
  "_npmVersion": "3.3.12",
...

It looks like that was installed because npm (why is that in node_modules??) required: "node-gyp": "~3.2.1".

Update: Ah, I think I finally found it! The culprit was ember-cli-release because of https://github.com/lytics/ember-cli-release/blob/3ea88c52e575c52b901e08b0dd900926b759d0b0/package.json#L30