3.2.0 fails in node 14
juliangruber opened this issue · comments
Julian Gruber commented
See eg juliangruber/parse-apache-directory-index#28
/Users/julian/dev/juliangruber/parse-apache-directory-index/node_modules/test/lib/internal/abort_controller.js:4
AbortController,
^
ReferenceError: AbortController is not defined
at Object.<anonymous> (/Users/julian/dev/juliangruber/parse-apache-directory-index/node_modules/test/lib/internal/abort_controller.js:4:3)
I wonder why tests didn't catch this. Is it because we pass our own AbortController implementation?
Antoine du Hamel commented
There's catch in the README:
Line 14 in 1401584
Antoine du Hamel commented
And here's how we're testing it:
node-core-test/.github/workflows/ci.yml
Lines 10 to 14 in 558abfc
node-core-test/.github/workflows/ci.yml
Lines 21 to 23 in 558abfc
Julian Gruber commented
Aah right I forgot about that. Thank you for pointing this out. I think this should have been a major version bump then.
Julian Gruber commented
shall we deprecate 3.2.0 and publish 4.0.0?