nodejs / node-convergence-archive

Archive for node/io.js convergence work pre-3.0.0

Home Page:https://github.com/nodejs/io.js/issues/2327

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Converge] repl: Private Buffer object in lib/* files

jasnell opened this issue · comments

See: nodejs/node-v0.x-archive@523929c
/cc @trevnorris

The original commit log says, "Fixes usage of global object 'Buffer' in lib/* files by ensuring that each file does an explicit require('buffer').Buffer. Previously, when running a repl, due to usage of global 'Buffer', any redefinition of Buffer would cause a crash eg var Buffer = {}."

This should be ported to io.js.

The plan is to add linting alongside doing an updated version of this. progress here: nodejs/node#1794

Landed a ported version in nodejs/node@b5b8ff1, notable difference is that the workaround for the race condition wasn't necessary any more.