Giters

nodejs / node-addon-examples

Node.js C++ addon examples from http://nodejs.org/docs/latest/api/addons.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Why do these two examples need a static FunctionReference?

seishun opened this issue · comments

commented

node-addon-examples/function-reference-demo/node-addon-api/src/native-addon.cc

Line 4 in c1bdff0

Napi::FunctionReference NativeAddon::constructor;

node-addon-examples/inherits_from_event_emitter/node-addon-api/src/native-emitter.cc

Line 7 in c1bdff0

Napi::FunctionReference NativeEmitter::constructor;

It's not referred anywhere other than the Init function and having an "immortal" Napi::FunctionReference seems unnecessary since the constructor isn't invoked from native code.

Curiously, these two examples were untouched by dc86a66, which replaced the usage of a static FunctionReference with instance data in examples that do need to keep the constructor alive.