Next release

[Michael Dawson]

We discussed issuing a SemVer major release to address #1272

The fix/tests have landed for that issue but I think we should also land #1266 since we marked that as SemVer major as well.

@nodejs/node-api any others we should try to include?

@NickNaso would you like to do the release?

[Nicola Del Gobbo]

yes I can. I will make the next release v6.0.0 after the PR #1266 will be landed.

[Michael Dawson]

@NickNaso thanks!. Just landed #1266

[Nicola Del Gobbo]

I'm starting to work on release v6.0.0.

[Nicola Del Gobbo]

CI:

Version	Job	Status
v19.x	https://ci.nodejs.org/job/node-test-node-addon-api-new/6950/	X
v19.x	https://ci.nodejs.org/job/node-test-node-addon-api-new/6954/	✓
v18.x	https://ci.nodejs.org/job/node-test-node-addon-api-new/6951/	✓
v16.x	https://ci.nodejs.org/job/node-test-node-addon-api-new/6952/	✓
v14.x	https://ci.nodejs.org/job/node-test-node-addon-api-new/6953/	✓

We have some problems on async_progress_worker test.
See:
https://ci.nodejs.org/job/node-test-node-addon-api-new/nodes=rhel8-ppc64le/6950/console
and
https://github.com/nodejs/node-addon-api/actions/runs/4082820116/jobs/7038141472
I want to discuss with you in the meeting before to land the new release on npm.

[Candylong]

When will the 6.0.0 release be

[Nicola Del Gobbo]

I think that I found the test that does not work:
https://github.com/nodejs/node-addon-api/blob/main/test/async_progress_worker.cc#L185
https://github.com/nodejs/node-addon-api/blob/main/test/async_progress_worker.js#L12

Anyone have an idea because this test hangs on Node.js v16 and x86 platform?

[Nicola Del Gobbo]

The new release has been published.