Giters

nodejs / llhttp

Port of http_parser to llparse

Home Page:http://llhttp.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

NPM install is in a broken state because of conflicting eslint-plugin/parser versions

ncgreene opened this issue · comments

commented

Automated tests are failing, for example the linter test fails: https://github.com/nodejs/llhttp/actions/runs/8633300953/job/23666034549

Copy/pasta of error logs 
Run npm ci --ignore-scripts
  npm ci --ignore-scripts
  shell: /usr/bin/bash -e {0}
  env:
    CI: true
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @typescript-eslint/eslint-plugin@7.0.0
npm ERR! Found: @typescript-eslint/parser@7.6.0
npm ERR! node_modules/@typescript-eslint/parser
npm ERR!   dev @typescript-eslint/parser@"^7.6.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @typescript-eslint/parser@"^6.0.0 || ^6.0.0-alpha" from @typescript-eslint/eslint-plugin@7.0.0
npm ERR! node_modules/@typescript-eslint/eslint-plugin
npm ERR!   dev @typescript-eslint/eslint-plugin@"^7.0.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @typescript-eslint/parser@6.[2](https://github.com/nodejs/llhttp/actions/runs/8633300953/job/23666034549#step:4:2)1.0
npm ERR! node_modules/@typescript-eslint/parser
npm ERR!   peer @typescript-eslint/parser@"^6.0.0 || ^6.0.0-alpha" from @typescript-eslint/eslint-plugin@7.0.0
npm ERR!   node_modules/@typescript-eslint/eslint-plugin
npm ERR!     dev @typescript-eslint/eslint-plugin@"^7.0.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /home/runner/.npm/_logs/2024-04-10T14_49_5[3](https://github.com/nodejs/llhttp/actions/runs/8633300953/job/23666034549#step:4:3)_505Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /home/runner/.npm/_logs/202[4](https://github.com/nodejs/llhttp/actions/runs/8633300953/job/23666034549#step:4:4)-04-10T14_49_[5](https://github.com/nodejs/llhttp/actions/runs/8633300953/job/23666034549#step:4:5)3_505Z-debug-0.log

Tests started failing with this commit: 48e5fd9

Going off the tests, merging in this PR would resolve the issue: https://github.com/nodejs/llhttp/pull/382/checks

commented

Fixed in #399.