node-test-linter broken due to CRLF in markdown files

Question

node-test-linter broken due to CRLF in markdown files

targos opened this issue 2 months ago · comments

Michaël Zasso commented 2 months ago

https://ci.nodejs.org/job/node-test-linter/
Example: https://ci.nodejs.org/job/node-test-linter/53842/console

Michaël Zasso · Answer 1 · Wed Mar 20 2024 22:13:16 GMT+0800 (China Standard Time)

It seems related to nodejs/node#52161, but CI wasn't run on that PR.

Richard Lau · Answer 2 · Wed Mar 20 2024 22:47:58 GMT+0800 (China Standard Time)

It seems related to nodejs/node#52161, but CI wasn't run on that PR.

Looks like this was run against that PR? https://ci.nodejs.org/job/node-test-linter/53839/

Richard Lau · Answer 3 · Wed Mar 20 2024 22:49:51 GMT+0800 (China Standard Time)

It seems related to nodejs/node#52161, but CI wasn't run on that PR.

Looks like this was run against that PR? https://ci.nodejs.org/job/node-test-linter/53839/

Although I am confused how we then had subsequent passing builds before https://ci.nodejs.org/job/node-test-linter/53842/console

Michaël Zasso · Answer 4 · Wed Mar 20 2024 23:01:36 GMT+0800 (China Standard Time)

I see only one subsequent passing build, which was started at the same time as 53840 and ran in another workspace (node-test-linter@2): https://ci.nodejs.org/job/node-test-linter/53841/console

Michaël Zasso · Answer 5 · Wed Mar 20 2024 23:03:47 GMT+0800 (China Standard Time)

I wiped out the workspace.

/cc @StefanStojanovic since it seems you started the first failing run.

Stefan Stojanovic · Answer 6 · Wed Mar 20 2024 23:19:39 GMT+0800 (China Standard Time)

hey @targos, yes I was the one to run that job to check if it would fail on that PR or not. after I saw it failed I told @huseyinacacak-janea to mark the PR as draft and ensure the linter job passes. Sorry to have broken CI, it should be fixed now.