Treating groups of commits as one unit
mscdex opened this issue · comments
In nodejs/node#10886 I noticed that at least for one particular PR, all but 1 of its commits were being included. I think it would be a good idea to first group commits by PR and then check that all of the commits from a particular PR are landable. If all of them aren't, then none of the commits should be included.
I think such a behavior should be default, but at the very least a command line option would be okay I suppose.
There was at least one PR that was composed of several commits. When the v7.x-staging branch was being updated to pull in backportable commits from master, it only pulled in some of the commits from that PR. I was suggesting that branch-diff should check that all commits for a PR are (cleanly) backportable before including any of the commits for a PR. This way you don't end up with a partially backported PR (which could break things).