Weird research in gensfen?

Question

Weird research in gensfen?

Sopel97 opened this issue 4 years ago · comments

https://github.com/nodchip/Stockfish/blob/master/src/learn/gensfen.cpp#L896-L900 What is the purpose of this? Could it be replaced by clamping search_depth_min to 1?

nodchip · Answer 1 · Sun Sep 13 2020 23:11:32 GMT+0800 (China Standard Time)

I'm not sure. It was written in the YaneuraOu, and I ported as-is. How about to ask in the YaneuraOu issues. https://github.com/yaneurao/YaneuraOu/issues

Tomasz Sobczyk · Answer 2 · Thu Sep 17 2020 16:35:46 GMT+0800 (China Standard Time)

yaneurao/YaneuraOu#121 (comment) Looks like it could be removed

nodchip · Answer 3 · Thu Sep 17 2020 16:40:11 GMT+0800 (China Standard Time)

I agree with you.

We are fixing regression between 2020-07-19 and 2020-08-30. It is a bit danger to change gensfen code in this timing. Could we remove it after the regression is fixed?

Tomasz Sobczyk · Answer 4 · Thu Sep 17 2020 17:15:33 GMT+0800 (China Standard Time)

yes, I think that's wise