Update System.Runtime.CompilerServices.Unsafe to version 6+

Question

Update System.Runtime.CompilerServices.Unsafe to version 6+

SonofNun15 opened this issue 2 years ago · comments

Because NuGet only resolves one version of each dependency, NodaTime is making it complicated to update other dependencies that rely on System.Runtime.CompilerServices.Unsafe and want version 6+. Would be useful if NodaTime moved to this version as well. Thanks!

Jon Skeet · Answer 1 · Fri Aug 05 2022 04:05:27 GMT+0800 (China Standard Time)

I'll have a look when I get a chance, but I'd expect you to be able to just depend on a later version and nuget will resolve to the most recent. Can you give a sample project file and what errors it's causing?

Josh Graber · Answer 2 · Fri Aug 05 2022 04:10:29 GMT+0800 (China Standard Time)

NU1605 errors. We may just need to turn these into warnings...

https://docs.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu1605?f1url=%3FappId%3DDev16IDEF1%26l%3DEN-US%26k%3Dk(NU1605)%26rd%3Dtrue

Josh Graber · Answer 3 · Fri Aug 05 2022 04:11:51 GMT+0800 (China Standard Time)

We're referencing Microsoft.Extensions.Http version 6.0.0, which needs System.Runtime.CompilerServices.Unsafe >=6.0.0. As you said, I think NuGet should be able to deal with this, but it's just unhappy because of the version discrepancies.

Jon Skeet · Answer 4 · Fri Aug 05 2022 04:23:41 GMT+0800 (China Standard Time)

What happens if you just add a dependency to System.Runtime.CompilerServices.Unsafe version 6 on your project?

Josh Graber · Answer 5 · Fri Aug 05 2022 21:16:04 GMT+0800 (China Standard Time)

We'll be fine. Had to explicitly add <WarningsAsErrors /> to our project files to get Visual Studio to stop displaying these warnings as errors. I may look into your suggestion about explicitly adding that reference just to limit the warnings.