noctux / philote

Ansible management for your OpenWRT router - with lua

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Snippet in README correct?

Moredread opened this issue · comments

Hi,

shouldn't it be name instead of pkg in the README for the dependency installation snippet?

Hey,

Are we talking about this part?

      - name: Installing dependencies for file-related modules
        opkg: pkg=luaposix,coreutils-sha1sum state=present update_cache=yes

I've got to admit that the use of "pkg" is not very ideomatic here, as I'm making use of an (undocumented, as fas as I know) alias. The alias is defined here.
It mirrors the alias present in ansible's upstream opkg module.

Hope this clarifies things :)
But maybe I should change that section. It was merely copied from my personal router config without too much consideration...

Oh, that makes sense.

I had problems getting that line to work, and after I rewrote it (using name) it worked, so I thought it was an issue with that. But it was just that the indentation was wrong after I pasted your snippet, i.e. it works fine now.

Glad to hear, closing this then for now :)

Feel free to notify me when other issues arise.