lispyville-delete will unbalance ending parens after a comment

Question

lispyville-delete will unbalance ending parens after a comment

sooheon opened this issue 9 years ago · comments

from

(foo
 ;; bar
 |baz)

dd gives me

(foo
 ;; bar)

I didn't notice this before, is this a recent change?

Fox Kiester · Answer 1 · Mon May 16 2016 20:57:35 GMT+0800 (China Standard Time)

Edit: Actually this has always been a problem. There is also another problem with comments in a selection. I'll fix this when I get the chance.

Fox Kiester · Answer 2 · Wed May 18 2016 23:13:05 GMT+0800 (China Standard Time)

dd specifically is fixed now. I should maybe also prevent closing delimiters being pulled into comments if the user tries to delete the following:

(a
;; ~b
c)|

Justin Burkett · Answer 3 · Thu Feb 02 2017 03:23:39 GMT+0800 (China Standard Time)

Here's a similar problem with comments that I just ran into. Case 1 is fine, but Case 2 gets you into a situation with unbalanced parens

;; CASE 1
(let ((a 1)
      (b 1))
  (+ a b))

;; dd on first line
((      (b 1))
  (+ a b))

;; CASE 2
(let (;; (a 1)
      (b 1))
  (+ a b))

;; dd on first line
(      (b 1))
  (+ a b))

Fox Kiester · Answer 4 · Thu Feb 02 2017 04:16:42 GMT+0800 (China Standard Time)

Thanks for reporting. I made a pull request to lispy to fix the issue.

Justin Burkett · Answer 5 · Thu Feb 02 2017 05:41:45 GMT+0800 (China Standard Time)

Thank you

…

On Wed, Feb 1, 2017 at 3:16 PM Fox Kiester ***@***.***> wrote: Thanks for reporting. I made a pull request to lispy to fix the issue. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACGyficzuIavlEcGbWclwUhI50hkhfOqks5rYOgqgaJpZM4IfEDH> .

Fox Kiester · Answer 6 · Thu Aug 24 2017 06:07:54 GMT+0800 (China Standard Time)

With the latest commit of lispy, this should no longer be an issue for the previously mentioned case.