[Guix] 5 tests fail
Ambrevar opened this issue · comments
The Guix package recently broke since the tests don't pass anymore:
Running 45 tests (2020-06-03 10:51:42+0000)
passed 1/45 lispyville-<
Indenting region...
Indenting region...done
passed 2/45 lispyville->
passed 3/45 lispyville-always-special
-- INSERT --
passed 4/45 lispyville-always-visual
passed 5/45 lispyville-backward-sexp
passed 6/45 lispyville-backward-up-list
Indenting region...
Indenting region...done
passed 7/45 lispyville-barf
passed 8/45 lispyville-beginning-of-defun
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
passed 9/45 lispyville-change
-- INSERT --
passed 10/45 lispyville-change-whole-line
Test lispyville-comment-or-uncomment backtrace:
signal(ert-test-failed (((should (string= (lispyville-with "(foo (ba
ert-fail(((should (string= (lispyville-with "(foo (bar (baz|\n quux)
(if (unwind-protect (setq value-487 (apply fn-485 args-486)) (setq f
(let (form-description-489) (if (unwind-protect (setq value-487 (app
(let ((value-487 (quote ert-form-evaluation-aborted-488))) (let (for
(let* ((fn-485 (function string=)) (args-486 (condition-case err (le
(lambda nil (let* ((fn-460 (function string=)) (args-461 (condition-
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name lispyville-comment-or-uncomment :docu
ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "elpa/elpa.el" "-l" "lispyville-test.el" "-l" "
command-line()
normal-top-level()
Test lispyville-comment-or-uncomment condition:
(ert-test-failed
((should
(string=
(lispyville-with "(foo (bar (baz|
quux)))" "gcc" ...)
"(;; foo
(;; bar
(;; baz|
quux)))"))
:form
(string= "(;; foo
(;; bar
(;; ba|z
quux)))" "(;; foo
(;; bar
(;; baz|
quux)))")
:value nil))
FAILED 11/45 lispyville-comment-or-uncomment
-- VISUAL BLOCK --
-- VISUAL BLOCK --
Test lispyville-delete backtrace:
signal(ert-test-failed (((should (string= (lispyville-with "(a\n ;;~
ert-fail(((should (string= (lispyville-with "(a\n ;;~ b\n c)|" "d")
(if (unwind-protect (setq value-187 (apply fn-185 args-186)) (setq f
(let (form-description-189) (if (unwind-protect (setq value-187 (app
(let ((value-187 (quote ert-form-evaluation-aborted-188))) (let (for
(let* ((fn-185 (function string=)) (args-186 (condition-case err (le
(lambda nil (let* ((fn-80 (function string=)) (args-81 (condition-ca
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name lispyville-delete :documentation nil
ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "elpa/elpa.el" "-l" "lispyville-test.el" "-l" "
command-line()
normal-top-level()
Test lispyville-delete condition:
(ert-test-failed
((should
(string=
(lispyville-with "(a
;;~ b
c)|" "d")
"(a
;;|
)"))
:form
(string= "(a
;|;
)" "(a
;;|
)")
:value nil))
FAILED 12/45 lispyville-delete
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
passed 13/45 lispyville-delete-back-to-indentation
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
passed 14/45 lispyville-delete-backward-word
Test lispyville-delete-char-or-splice backtrace:
signal(ert-test-failed (((should (string= (lispyville-with "(a|)" "x
ert-fail(((should (string= (lispyville-with "(a|)" "x") "a|")) :form
(if (unwind-protect (setq value-237 (apply fn-235 args-236)) (setq f
(let (form-description-239) (if (unwind-protect (setq value-237 (app
(let ((value-237 (quote ert-form-evaluation-aborted-238))) (let (for
(let* ((fn-235 (function string=)) (args-236 (condition-case err (le
(lambda nil (let* ((fn-225 (function string=)) (args-226 (condition-
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name lispyville-delete-char-or-splice :doc
ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "elpa/elpa.el" "-l" "lispyville-test.el" "-l" "
command-line()
normal-top-level()
Test lispyville-delete-char-or-splice condition:
(ert-test-failed
((should
(string=
(lispyville-with "(a|)" "x")
"a|"))
:form
(string= "|a" "a|")
:value nil))
FAILED 15/45 lispyville-delete-char-or-splice
Test lispyville-delete-char-or-splice-backwards backtrace:
signal(ert-test-failed (((should (string= (lispyville-with "(a)|" "X
ert-fail(((should (string= (lispyville-with "(a)|" "X") "a|")) :form
(if (unwind-protect (setq value-292 (apply fn-290 args-291)) (setq f
(let (form-description-294) (if (unwind-protect (setq value-292 (app
(let ((value-292 (quote ert-form-evaluation-aborted-293))) (let (for
(let* ((fn-290 (function string=)) (args-291 (condition-case err (le
(lambda nil (let* ((fn-280 (function string=)) (args-281 (condition-
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name lispyville-delete-char-or-splice-back
ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "elpa/elpa.el" "-l" "lispyville-test.el" "-l" "
command-line()
normal-top-level()
Test lispyville-delete-char-or-splice-backwards condition:
(ert-test-failed
((should
(string=
(lispyville-with "(a)|" "X")
"a|"))
:form
(string= "|a" "a|")
:value nil))
FAILED 16/45 lispyville-delete-char-or-splice-backwards
-- VISUAL BLOCK --
-- VISUAL BLOCK --
passed 17/45 lispyville-delete-line
passed 18/45 lispyville-drag-backward
passed 19/45 lispyville-drag-forward
passed 20/45 lispyville-end-of-defun
-- INSERT --
-- INSERT --
passed 21/45 lispyville-escape
passed 22/45 lispyville-first-non-blank
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
passed 23/45 lispyville-forward-atom-begin
passed 24/45 lispyville-forward-sexp
-- INSERT --
passed 25/45 lispyville-insert
passed 26/45 lispyville-insert-at-beginning-of-list
passed 27/45 lispyville-insert-at-end-of-list
Test lispyville-join backtrace:
signal(ert-test-failed (((should (string= (lispyville-with "|foo" "J
ert-fail(((should (string= (lispyville-with "|foo" "J") "foo|")) :fo
(if (unwind-protect (setq value-517 (apply fn-515 args-516)) (setq f
(let (form-description-519) (if (unwind-protect (setq value-517 (app
(let ((value-517 (quote ert-form-evaluation-aborted-518))) (let (for
(let* ((fn-515 (function string=)) (args-516 (condition-case err (le
(lambda nil (let* ((fn-500 (function string=)) (args-501 (condition-
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name lispyville-join :documentation nil :b
ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "elpa/elpa.el" "-l" "lispyville-test.el" "-l" "
command-line()
normal-top-level()
Test lispyville-join condition:
(ert-test-failed
((should
(string=
(lispyville-with "|foo" "J")
"foo|"))
:form
(string= "fo|o" "foo|")
:value nil))
FAILED 28/45 lispyville-join
passed 29/45 lispyville-next-closing
passed 30/45 lispyville-next-opening
passed 31/45 lispyville-open-above-list
passed 32/45 lispyville-open-below-list
passed 33/45 lispyville-prettify
passed 34/45 lispyville-previous-closing
passed 35/45 lispyville-previous-opening
passed 36/45 lispyville-raise-list
passed 37/45 lispyville-slurp
-- INSERT --
-- INSERT --
passed 38/45 lispyville-substitute
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
-- INSERT --
passed 39/45 lispyville-toggle-mark-type
passed 40/45 lispyville-up-list
passed 41/45 lispyville-wrap-lispy-mark-symbol
passed 42/45 lispyville-wrap-round
Indenting region...
Indenting region...done
Indenting region...
Indenting region...done
passed 43/45 lispyville-wrap-with-round
Mark set
Mark set
Mark set
Mark set
Mark set
Mark set
-- VISUAL BLOCK --
Mark set
-- VISUAL BLOCK --
Mark set
-- VISUAL BLOCK --
passed 44/45 lispyville-yank
Mark set
-- VISUAL BLOCK --
Mark set
-- VISUAL BLOCK --
Mark set
passed 45/45 lispyville-yank-line
Ran 45 tests, 40 results as expected, 5 unexpected (2020-06-03 10:51:47+0000)
5 unexpected results:
FAILED lispyville-comment-or-uncomment
FAILED lispyville-delete
FAILED lispyville-delete-char-or-splice
FAILED lispyville-delete-char-or-splice-backwards
FAILED lispyville-join
make: *** [Makefile:12: test] Error 1
Any idea?
The Guix package depends on Evil 1.14 and Lispy 0.27.
Yeah, the tests have been broken with the latest lispy/evil. I haven't had time to look at it yet. Do you happen to know how recently they broke? I'll try to look at it this week.
On Guix, lispy hasn't moved since 0.27 (some years ago). So I guess the
culprit is Evil 1.14 then.
I have all the tests passing locally now (though I'm surprised you didn't have 6 failures). Of course, different tests are failing with Emacs 26.3 on CI. Maybe this won't matter for the Guix package? With what Emacs are the tests run for Guix?
Emacs 26.3.
Everything passes locally for me with Emacs 26.3. I'm going to have to look into it further why things are failing with github actions... Let me know if the tests are working for you as well now or if you are getting failures.
It's working now, thanks!
Great! I will make a separate issue for CI problems.