view.layer.shadowOffset is hardcoded to CGSize.zero

Question

allentomdude opened this issue 5 years ago · comments

Hello, UIView.generateOuterShadow() always sets the shadow directly underneath the view, and ignores the view's layer.shadowOffset.

Line 20 of UIView.swift generateOuterShadow() currently is:

    view.layer.shadowOffset = CGSize.zero

Should be updated to:

  view.layer.shadowOffset = layer.shadowOffset

In order to be able to position the outer shadow horizontally or vertically. I'll be happy to submit a pull request if you'd like.

Luan Tran · Answer 1 · Sun Jun 23 2019 22:04:41 GMT+0800 (China Standard Time)

@allentomdude Yes, please make a pull request and update shadowOffset in generateInnerShadow , generateEllipticalShadow too.

Thank you.

Luan Tran · Answer 2 · Tue Jun 25 2019 23:25:33 GMT+0800 (China Standard Time)

Fixed it, thank you man.