Review of the kl_divergence_profile function
noahbouchier opened this issue · comments
Hey - having just updated the function, based upon the feedback from the recent code review pull request. I'd be appreciative of further feedback on the kl_divergence_profile.py function!
By opening up an issue, as well as receiving a code review, I aim to update with any questions I have on the inner workings of the function. None of these are particularly major, but I hope to sit down and write them down tomorrow.
Hey Noah!
Great job polishing the function and getting everything to near completion. I push my changes directly to the branch because I forgot I had full write access, so you can see the minor changes I made here (519a403). Reminder that you will need to git pull to have these changes reflected locally.
Summary of the changes I made:
- Code formatting (long lines to multiple lines, consistent variable style, removing white space)
- Adding two helper functions to the demo to ensure someone can try the function
Everything else looks great! The only remaining comment I have is that the function, in its current form, does not seem to require geopandas. We might assume that someone is passing a geodataframe, but the function doesn't actually use any functionality from geopandas (unless it is for .centroid?).
Otherwise all good on my end! I think you are good to open a PR to segregation so @knaaptime can get eyes on it!
awesome. Looks like there's been more work here than has been pushed to the open PR in segregation, so just let me know when/if you'd like a review here or over there :)