nix-rust / nix

Rust friendly bindings to *nix APIs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

api inconsistency Epoll::modify and Epoll::add

dimbleby opened this issue · comments

Epoll::add takes mut event: EpollEvent, whereas Epoll::modify takes event: &mut EpollEvent

seems like an odd difference, am I missing a reason that this is sensible?

There is no strong reason.

Epoll::add could takes &mut EpollEvent,it may make sense to make a PR for this.