Timing autoFix (Parasite Eve 2, Vandal Hearts) broken on WiiSXRX 3.2 (3.0 and 3.1 works)

Question

Timing autoFix (Parasite Eve 2, Vandal Hearts) broken on WiiSXRX 3.2 (3.0 and 3.1 works)

saulfabregwiivc opened this issue 2 years ago · comments

saulfabreg Wii VC Project commented 2 years ago

Hey there @niuus,

Thanks for your work with WiiSXRX.

A critical bug report: the timing autoFix function (which fixes Parasite Eve 2, Vandal Hearts) on 3.2 now it's broken on all builds (3.0 and 3.1 work though).

Can you see in the code what's going on and in what modification actually break the timing autoFix?

You know, i'm currently making some modifications for add more autoFixes, and tidy up the timing autoFix (all from @xjsxjs197's repo), for later send you a PM for 3.3, but I couldn't get the timing autoFix working due of being broken since 3.2.

Can you check this please? Thanks!!!

@saulfabregwiivc

niuus · Answer 1 · Mon Oct 31 2022 22:52:17 GMT+0800 (China Standard Time)

Hey there @niuus,

Thanks for your work with WiiSXRX.

A critical bug report: the timing autoFix function (which fixes Parasite Eve 2, Vandal Hearts) on 3.2 now it's broken on all builds (3.0 and 3.1 work though).

Can you see in the code what's going on and in what modification actually break the timing autoFix?

You know, i'm currently making some modifications for add more autoFixes, and tidy up the timing autoFix (all from @xjsxjs197's repo), for later send you a PM for 3.3, but I couldn't get the timing autoFix working due of being broken since 3.2.

Can you check this please? Thanks!!!

Yep, I had to take the manual fix out temporarily as it clashed with the GTE updates on compilation. That's why I mentioned in the forums that if you want to do a PR and make it work, i'll integrate it. I really want to spend some time doing the finishing touches to get NeoCDRX out before 2023, as I have some versions ready.

saulfabreg Wii VC Project · Answer 2 · Tue Nov 01 2022 08:04:25 GMT+0800 (China Standard Time)

Okay, i think i spotted the problem.

This problem doesn't just happen on WiiSXRX, it's being broken also on WiiStation, in the commit xjsxjs197/WiiSXRX_2022@0f1eb82.

I've opened an issue of this critical bug here too: xjsxjs197/WiiSXRX_2022#48

When xjsxjs197 fixes said bug, i will integrate the fix to my PR i'm currently doing.

EDIT: @niuus , sorry for being just stupid and didn't check the WiiStation repo first for confirm said problem.

saulfabreg Wii VC Project · Answer 3 · Tue Nov 01 2022 20:48:37 GMT+0800 (China Standard Time)

Closing issue, this was fixed on WiiStation as of commit xjsxjs197/WiiSXRX_2022@d5df2fb

I've opened a PR which fixes said issue on WiiSXRX ;) #79