Set Go Redis V7 Client Problem

Question

Set Go Redis V7 Client Problem

rainlay opened this issue 5 years ago · comments

HI, I want so set the goredis/v7 to use rejson, but when I set the client,

the error shows:

Cannot use (type *"github.com/go-redis/redis/v7".Client) as type *"github.com/go-redis/redis".Client

looks like the lib only accept "github.com/go-redis/redis" (v6),

can fix the problem? thanks..

Nitish Malhotra · Answer 1 · Mon Dec 23 2019 23:24:34 GMT+0800 (China Standard Time)

Is there a particular reason you need to upgrade to v7 ? Not that it is not possible, I am just curious to know.

RAIN · Answer 2 · Tue Dec 24 2019 10:03:12 GMT+0800 (China Standard Time)

Is there a particular reason you need to upgrade to v7 ? Not that it is not possible, I am just curious to know.

not for a really necessary reason, I was just using the newest version for go-redis, maybe I will rollback to v6 for using rejson...

Nitish Malhotra · Answer 3 · Tue Dec 24 2019 23:28:15 GMT+0800 (China Standard Time)

We could update the go mod with the latest, but I suspect you are not using go modules. If you switch to go modules in your project it should select the lowest compatible version (in this case v6) unless you explicitly import v7 in your source.

RAIN · Answer 4 · Fri Dec 27 2019 10:25:21 GMT+0800 (China Standard Time)

Hi nitishm, I am using go mod, I was explicitly import go-redis v7 version (follow the go-redis github readme)

Nico Mürdter · Answer 5 · Mon May 18 2020 14:33:50 GMT+0800 (China Standard Time)

Hi, is the upgrade to go-redis v7 still on hold right now? I would love to use rejson with the new client as v7 fixes some major issues with commands like HMSet and, while it's no dealbreaker, importing two different versions of go-redis seems kind of unfortunate.

Vadim Filin · Answer 6 · Wed Jul 08 2020 18:10:35 GMT+0800 (China Standard Time)

@nitishm Hi! Why don't you like interfaces?
cannot use redisCli (type *"github.com/go-redis/redis/v7".Client) as type *"github.com/go-redis/redis".Client in argument to rh.SetGoRedisClient

Nitish Malhotra · Answer 7 · Wed Jul 08 2020 21:11:46 GMT+0800 (China Standard Time)

@filinvadim I am open to switching to interfaces. Feel free to take on the task and open a PR if you feel up to it 😄 . If not @Shivam010 would you be willing to take this on?

Shivam Rathore · Answer 8 · Wed Jul 08 2020 21:25:23 GMT+0800 (China Standard Time)

Sure, I'll look into this by the week end

Shivam Rathore · Answer 9 · Tue Jul 14 2020 05:20:25 GMT+0800 (China Standard Time)

@nitishm There can be two possible solutions to the problem.

Using an interface with a Do(...interface{}) (interface{}, error) method instead of the go-redis clients
Or we can release a new version by manually updating the client version.

The first one will remove the client version dependency but will require the user to wrap the client object into the interface.
And the second one will only require a version change in go mod for the corresponding client version.

Nitish Malhotra · Answer 10 · Wed Jul 15 2020 04:01:32 GMT+0800 (China Standard Time)

Prefer the 2nd one @Shivam010

Shivam Rathore · Answer 11 · Wed Jul 15 2020 04:16:06 GMT+0800 (China Standard Time)

Me too. That's why I haven't drafted the PR. Sh

…

On Wed, Jul 15, 2020 at 1:31 AM Nitish Malhotra ***@***.***> wrote: Prefer the 2nd one @Shivam010 <https://github.com/Shivam010> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#37 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG5ZBWVKKWULRZ4IFMNRCXLR3S2SVANCNFSM4J6Q6KWQ> .