nitin42 / react-perf-devtool

A browser developer tool extension to inspect performance of React components.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Uncaught TypeError: Cannot read property 'length' of null after clear button

mauricedb opened this issue · comments

After using the Clear button the Chrome extension throws the following error:

Chart.js:12635 Uncaught TypeError: Cannot read property 'length' of null
    at Object.acquireContext (Chart.js:12635)
    at Chart.construct (Chart.js:4608)
    at new Chart (Chart.js:7234)
    at t.drawChart (ReactPerfDevtool.js:1)
    at t.updateMeasures (ReactPerfDevtool.js:1)
    at ReactPerfDevtool.js:1
    at callbackWrapper (<anonymous>:53:1)
    at ExtensionServerClient._onCallback (<anonymous>:66:653)
    at ExtensionServerClient._onMessage (<anonymous>:67:9)
acquireContext @ Chart.js:12635
construct @ Chart.js:4608
Chart @ Chart.js:7234
drawChart @ ReactPerfDevtool.js:1
updateMeasures @ ReactPerfDevtool.js:1
(anonymous) @ ReactPerfDevtool.js:1
callbackWrapper @ VM253:53
_onCallback @ VM253:66
_onMessage @ VM253:67

It would appear to be caused by https://github.com/nitin42/react-perf-devtool/blob/master/src/extension/components/ReactPerfDevtool.js#L150 not finding the DOM element with ID myChart and calling new Chart(null, ...)

Fixed 😄 Uploading the extension now so the update should be out in 30 minutes!