nitin42 / animate-components

✨ Elemental components for doing animations in React

Home Page:http://animate-components.surge.sh/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Inferno support?

NuroDev opened this issue · comments

commented

Are there any plans of adding support for InfernoJS?
Would be a nice addition if possible 😄 ❤️

I'd earlier (it's in my list though) but currently I am working on transitioning between the components. If things go well, I would land the support for InfernoJS!

I haven't use InfernoJS. How's that different from React ? Any core primitives ?

commented

Basically a lightweight React that's faster and smaller and as far as I have looked into it so far, a fair few of the core react components are the same in Inferno.
But I may be wrong 😕

I tried Inferno and must say it has a great performance ! I ran a demo of animate-components with Inferno-compat and it worked but it gave me some strange errors. Seems like I will adding support for Inferno and Preact in next release (already started working!)

Published v1 for Inferno ! Try installing it and let me know.

npm install ac-inferno --save

The api is same (though I will be publishing the docs soon)

There is still some work to do but things should work for now. Expect a stable release soon !

Remaining -

  • Better error warnings
  • Reduce build size
  • Docs for some changes
  • Code cleanup
commented

Tested it a basic InfernoJS app and basic usage worked perfectly \o/
Sadly usage in a electron-forge inferno app doesn't work. Though I think the error is more to do with the community made InfernoJS template.
Seems to still be a react import in a electron module 😕

C:\Users\Meadowcottage\Desktop\inferno\node_modules\electron-prebuilt-compi…dules\electron\dist\resources\electron.asar\common\reset-search-paths.js:1

Uncaught Error: Cannot find module 'react'

Did you tried Inferno-compat and configuring your webpack ?

I've tested everything from my side and it works !

Resolving the aliases or resetting your webpack should work. I don't know much about the build process for electron framework.

commented

Sadly the electron-forge system doesn't use webpack 😕
Here's an example of the electron-forge file structure/setup: github.com/owstat/owstat

Ok. I don't know much about electron-forge !

Released the stable version for InfernoJs ac-inferno@1.0.3. Hope you find a solution for electron-forge !

commented

So after testing it, I was able to get it working with electron-forge by adding react as a dev dependency.
So far that seems to be the only work around for the error that electron-prebuilt-compile is returning.

Great!

commented

If I find a way to get around having to add react as a dev dependency, then i'll reply to this thread letting you know 😄

Sure 😄