nitin42 / animate-components

✨ Elemental components for doing animations in React

Home Page:http://animate-components.surge.sh/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

build issue with react-attributes?

th3fallen opened this issue · comments

@nitin42

It appears im getting this with react-attributes which is published by you but i cant find a repo for it.

Unexpected token: name (shouldNotBeUndefined) [./~/react-attributes/index.js:3,0][assets/js/vendor-f4077c28349e66b94f3a.js:78808,4]

any ideas?

had to downgrade to 0.9.0 until i get this sorted 😢

What are you looking for ? react-attribute package ? or is it related to the lib ?

it's from react-attribute which this lib uses

I haven't push the code for the react-attribute on GitHub. But there should be no such errors as far as I am concern !?

anything over v0.9.0 wont build with uglify v1 is the first time that dep is introduced and the error is coming from a method in it so ¯_(ツ)_/¯

I am merging the code from that package into the lib and removing it as a dependency. I am gonna publish a new update. Can you wait for.. 20 minutes ?

i've already reverted but i'll reupdate and test the build then, just let me know. updating is only 2 changes for me atm so it's pretty painless

Great!

Published 1.1.6. Check and let me know !

That works! 🙇

Changes -

  • containers refactored (HOC.js and merge.js)
  • added eslint comments.
  • removed react-attributes package.
  • some other fixes

Great again !