Upgrade Node version to 18
andyduong1920 opened this issue · comments
Why
As 18 is the latest Node LTS version. There is 2 blockers in upgrade to Node 18
@nimblehq/stylelint-config-nimble
=> This is now fixed and this issue is unlocked! 🚀
@nimblehq/eslint-config-nimble
=> This is not fixed yet ❌ nimblehq/eslint-config-nimble#56
Who Benefits?
Developers
Hi @andyduong1920 ,
@nimblehq/eslint-config-nimble version 2.4.0 doesn't support node 18. It seems here that supporting version 2.6.0 has been released in github, but it isn't available in npm registry.
Looking for your suggestion about the way forward.
@mosharaf13 could you reach out to @carryall as she is the maintainer for these packages 🙏
And also, to be clear, I do not => This is now fixed and this issue is unlocked! 🚀 :D because I don't know the state of the [@nimblehq/stylelint-config-nimble](https://github.com/nimblehq/stylelint-config-nimble) :D I just now that we can't use Node 18 at this moment hehe
So the way to go is double check with the Javascript guild (@carryall) For this topic over Slack #js-guild channel @mosharaf13
@andyduong1920 wasn't this fixed by nimblehq/stylelint-config-nimble#13 ? 👀
@andyduong1920 wasn't this fixed by nimblehq/stylelint-config-nimble#13 ? 👀
I'm not sure @malparty, could you check the status with @carryall or @hoangmirs
@malparty @andyduong1920 Yeah, it was released in 1.0.3
So you can upgrade that dependency to continue on this issue 🎉
@malparty @andyduong1920 Yeah, it was released in 1.0.3 So you can upgrade that dependency to continue on this issue 🎉
I doubt that is not actually ready @hoangmirs https://nimble-co.slack.com/archives/C01GL6RBW11/p1690427376112969?thread_ts=1689327996.399969&cid=C01GL6RBW11
Oh, that is about eslint-config-nimble
@hoangmirs @malparty I have updated the ticket description to make it clear, we have 2 blockers actually, one was fixed and another one is still there, that why we can't upgrade the Rails template to Node 18 yet ;)
@andyduong1920 I just realized #490 resolved this issue 🥳 🥳 🥳