nimblehq / gin-templates

Our optimized Gin templates used in our projects

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[RFC] Split tests into several files

malparty opened this issue · comments

Why

The current cmd/create_test.go file is becoming very long (and will become longer!).

Impacts:

  • Some rebase generate conflicts headache (due to the code high resemblance).
  • Makes maintaining tests harder

Who Benefits?

Developers for

  • maintenance tasks
  • new features

Poll

3 options:

  1. Keep as current (1 single big file `create_test.go)
  2. Add 1 *_test.go file per add-ons/variant. This would go against our Go conventions so let's open a discussion here.
  3. Keep create_test.go for core tests and have it to import (and run) other sub-files (1 per add-ons/variant).



I voted for 2 because this case is worth breaking the golang convention as it is easier to maintain.