[NIM] Thread completion triggers thread sanitizer warnings
shayanhabibi opened this issue · comments
Thread analyzer determines the deallocshared proc called by a thread on completion is a data-race.
Atm only solution I can come up with involves changing or providing a modified std lib thread library that corrects this behaviour. The safest methodology is having the pointer deallocshared acts on being atomically stored and loaded for destruction? Haven't look too deep into it yet.
I now see the problem is definitely more convoluted and it is not isolated to just the thread deallocation. Numerous other issues are raised despite our own safe understanding of the order of operations with deallocations in loony. For now I think more involved tests that actually have work and require memory coherance to arrive at correct computations is required.
Nim's allocator is buggy and --define:useMalloc is the only realistic way forward.