Do not override GitHub labels but rather add and remove
nikku opened this issue · comments
Describe the Bug
The board forcefully overrides column labels when issues are being moved via automatic dev flow. This can lead to the situation that labels added by external parties are being overridden.
Steps to Reproduce
- External party opens PR
- Board moves PR to
needs review - External party adds
foolabel - Board resets labels, dropping
foo, addingneeds review
Expected Behavior
- Board only adds and removes labels it controls itself. No additional labels are being touched.
Environment
- Browser: Any
- OS: Any
- Board Version: v0.29.0
@piyushk I've seen you fixed this via https://github.com/SonyAI/wuffle_contrib/commit/1f2dac09742fcb2988efdbd82bec74508f7f0a67.
Did it work without unintended side-effects? Do you mind if I adopt your solution?
I'm afraid there are side-effects, which is why I never PRed the solution. Since there is a short delay between add/remove, the card tends to jump around on the board. For instance, If I move the card from In Review to In Progress (i.e left) manually, I add the In Progress label and then remove the In Review label. The card jumps to In Progress, back to In Review, and then to In Progress. As long as you're moving cards right (typical flow), I think the behavior works fine.
Please feel free to adopt the solution however you'd like if you can resolve the side-effect above. I had to implement it because wuffle was removing a label added by a different bot.
Thanks for the heads up. Will need to wrap my head around that issue then, some day 😉
Closed via 2ab671c.