nielstron / quantulum3

Library for unit extraction - fork of quantulum for python3

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Does not support numeric abbreviation

roniemartinez opened this issue · comments

Is your feature request related to a problem? Please describe.
parser.parse cannot properly parse numeric abbreviations

>>> parser.parse("1k miles")
[Quantity(1, "unk mile")]
>>> parser.parse("1K miles")
[Quantity(1, "kelvin mile")]
>>> parser.parse("1M miles")
[Quantity(1, "metre mile")]

Describe the solution you'd like
Should be able to parse numeric abbreviations properly:

In English numeric abbreviations and currency:
K for thousand (from kilo)
M for million
B for billion
T for trillion

In metric prefixes for SI measurements:
k for thousand (note lowercase)
M for million (from mega)
G for billion (from giga)
T for trillion (from tera)

Reference: https://english.stackexchange.com/a/112250

Good point! This is about to come. I'm working on this and composite units in branch fix-combined-units

Fixed by #21. Please have a look into it, if it behaves as expected.

Hi @nielstron

It works on my end now. When are you going to release it on PyPI? I see that you've added scipy into it. Will it be using scipy heavily?

scipy will not be used much more than in previous versions. It should not even be a requirement for the package. Please contact me if this is wrong.

New version is out now, including this fix

Thanks @nielstron

Cheers! 👍