nicoverbruggen / phpmon

Lightweight, native Mac menu bar app that helps you manage multiple PHP installations, locate config files and more. Also interacts with Laravel Valet.

Home Page:https://phpmon.app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Sort by domains instead of absolute path

epigeyre opened this issue · comments

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Hi,

Thanks a lot for this awesome app!! I've just noticed a small issue:

  • When I sort the Domain list by Domain it does not sort domains by domain name url in ASC or DESC order. The sorting appears to be a bit random.

Expected Behavior

  • The domains should be ordered by domain url in either ASC or DESC order.

Steps To Reproduce

  • Add several domains
  • Click on the domain column

Environment

- macOS: Ventura 13.4.1 (c) on Apple M2 Pro
- Valet: 3.3.2
- PHP Monitor: 6.0.1

Do you have a log file (or a screenshot) or any additional information?

No response

The sorting applied is currently based on the absolute path on the filesystem, not the domain name. So unless that particular sorting is broken, I consider this to be working as intended!

(Although perhaps it would make more sense to sort by domain name, indeed. I'll keep this issue open and will take a look later when I'm back from my two-week break.)

Thanks for your answer!

You are right, sorry I didn't realize it was using the absolute path. This works perfectly if all sites are in the same folder. However this is not how I work as I have one folder per client under different groups.

Form a UX point of view maybe it would make more sense to sort by the most visible information in the column (which is the domain url for the domain column)...

Just thinking out loud, this is not very important ;). Enjoy your break!