nickstenning / honcho

Honcho: a python clone of Foreman. For managing Procfile-based applications.

Home Page:http://pypi.python.org/pypi/honcho

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Why start_new_session=True ? (sorry not really an issue)

Tobi-De opened this issue · comments

Hello, I hope you are doing great. This is a question rather than an issue. I recently had to use Honcho in a way that required it to run in the current user session. The default setting for Python's subprocess.Popen is to have start_new_session as False, but in Honcho, it was overridden and changed to True.

class Popen(subprocess.Popen):

    def __init__(self, cmd, **kwargs):
        start_new_session = kwargs.pop('start_new_session', True)

I'm primarily asking this out of genuine curiosity. I've resolved my issue by overriding the class and setting start_new_session back to False, but I'm wondering why it was changed in the first place. What am I missing here?