Test -testRezipZippedData is pointless.

[dmrev]

It tests nil equal to nil.

[Nick Lockwood]

It does? It shouldn't… it's supposed to check that calling zippedData on already zippedData returns the same value instead of re-applying the zip function.

[dmrev]

- (void)testRezipZippedData
{
    //set up data
    NSString *inputString = @"Hello World!";
    NSData *inputData = [inputString dataUsingEncoding:NSUTF8StringEncoding];

    //compress
    NSData *compressedData = [inputData gzippedData];
    inputString = [[NSString alloc] initWithData:compressedData encoding:NSUTF8StringEncoding]; <-- doesn't make sense, returns nil, on swift - crashes.

    //compress again
    NSData *outputData = [compressedData gzippedData];
    NSString *outputString = [[NSString alloc] initWithData:outputData encoding:NSUTF8StringEncoding]; <-- doesn't make sense, returns nil, on swift - crashes.
    XCTAssertEqualObjects(outputString, inputString); <-- doesn't make sense.
}

I think, it should be:

func testRezipZippedData() {
        // setup
        let inputString: NSString = "Hello World!"
        let inputData = inputString.dataUsingEncoding(NSUTF8StringEncoding)!

        // compress
        let compressedData = inputData.gzippedData()!

        // compress again
        let outputData = compressedData.gzippedData()!
        let outputString = NSString(data: outputData.gunzippedData()!, encoding: NSUTF8StringEncoding)
        XCTAssertEqual(outputString, inputString)
}

[Nick Lockwood]

Hmm, you're right. Thanks.

[Nick Lockwood]

Fixed.