nice-registry / all-the-package-names

Your is a lovely package and this is not a real issue, rather curiosity, but I was wondering the reason behind lodash as dependency.

In line 20

all-the-package-names/script/build

Line 20 in 3369886

if (name && name.length && !names.includes(name)) names.push(name)

you ignore falsy values like compact would do, with a check on name.length that is also not needed since empty strings are falsy already so if ('') { alert(1); } never happens, and you filter duplicates via array.includes(name) like uniq, and after you get again all values you had before.

Not only you could've simply used an if (name) names.add(name) having names as new Set instead of an Array, you could also easily get rid of lodash as dependency.

You know, you're somehow responsible for its score in the top 10 😄

Am I missing something obvious in your code?

Would be so kind to explain me why you need lodash here?

Hey there. Somehow I missed this issue back when you created it. If you would like to submit a PR that change this, I'd be open to it. Thanks!

sorry, not as important, no time for PR.

closing this as personal github issues clean-up duty

personal github issues clean-up duty

Feels good, right?

Off-topic: @groundwater did manage to get Electron building on ARM64. I was supposed to remind you when that happened, right?

good to know, thanks.

Do you know if also npm i electron works on ARM64 ?

We started including ARM64 builds as of 1.8.1, which hasn't yet stabilized: https://github.com/electron/electron/releases/tag/v1.8.1

You can install the latest beta with npm i -D electron@beta

I need my SBCs with me, which won't happen before middle January so ... thanks for the heads up, I'll come back!

line 20 makes lodash redundant?