build.sh: sed -i command not working on macos

Question

build.sh: sed -i command not working on macos

jasonestewart opened this issue 6 years ago · comments

jasonestewart commented 6 years ago

on macos sed -i needs a backup prefix - once I changed the command to sed -i.bu things worked properly

Nicco Kunzmann · Answer 1 · Thu Jan 17 2019 06:35:35 GMT+0800 (China Standard Time)

I guess, you ran the build.sh file.

What is the error you see?
What does .bu do?
Would you like to create a pull request so I can try it out?

jasonestewart · Answer 2 · Thu Jan 17 2019 17:44:26 GMT+0800 (China Standard Time)

Hey Nicco,

Yes, sorry, I ran the build.sh and it failed.

The -i flag to sed can be given a parameter which is used to create a backup file of the original files before they are modified in-place - on platforms that use GNU sed that parameter is optional, macos doesn't use GNU sed, so the parameter is required. So -i.bu tells sed to make a backup of each file with the extension '.bu' appended to the original file.

Sadly, my solution doesn't actually work properly. The script runs and the book is made but now each character is duplicated - once for the .txt file and once for the .txt.bu file!! I believe the solution is to use the command sed -i '' on macos which means that it won't create a backup file. I will test it and post here again

jasonestewart · Answer 3 · Thu Jan 17 2019 17:49:50 GMT+0800 (China Standard Time)

I tried the sed -i '' and it worked properly on macos - I don't have access to my linux machine any more so I can't test it there. If you could test it and make sure that it doesn't break anything then that would be a fix that is cross-platform.

Nicco Kunzmann · Answer 4 · Thu Jan 17 2019 18:32:54 GMT+0800 (China Standard Time)

Sed -i would be the same as sed FILE > FILE would you can try this, too. If you like, you can edit the file and commit it to another branch. The CI Travis runs on a linux machine. If that works, it works. I will test it, too - we can see the output on "I did the math". The [ ] brackets should show up correctly. There if it works.

…

On 1/17/19 10:49 AM, jasonestewart wrote: I tried the |sed -i ''| and it worked properly on macos - I don't have access to my linux machine any more so I can't test it there. If you could test it and make sure that it doesn't break anything then that would be a fix that is cross-platform. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAieIKguDRSiJhrK7TDFiyVER5iSJQBPks5vEEc_gaJpZM4aBtz->.

Nicco Kunzmann · Answer 5 · Sat Jan 19 2019 03:45:22 GMT+0800 (China Standard Time)

#21 fixes this, so I close this. If there are issues again, we can re-open.