Question about error constants
ssteiger opened this issue · comments
Hey!
Quick question:
Why are the error constants in ownable.sol
public:
string public constant NOT_CURRENT_OWNER = "018001";
string public constant CANNOT_TRANSFER_TO_ZERO_ADDRESS = "018002";
And the error constants in nf-token.sol
private? :
string constant ZERO_ADDRESS = "003001";
string constant NOT_VALID_NFT = "003002";
string constant NOT_OWNER_OR_OPERATOR = "003003";
string constant NOT_OWNER_APPROVED_OR_OPERATOR = "003004";
string constant NOT_ABLE_TO_RECEIVE_NFT = "003005";
string constant NFT_ALREADY_EXISTS = "003006";
string constant NOT_OWNER = "003007";
string constant IS_OWNER = "003008";
Is there a reason for that, or does it just not matter?
Is there any harm in making them all private?
Thanks!
Just a design decision.
Cool, thanks!