Add test cases around new EXTCODEHASH behavior

Question

fulldecent opened this issue 5 years ago · comments

The behavior of this implementation was changed slightly with the switch to EXTCODEHASH. Let's document this using test cases.

Mocks:

Contract R
- Has a token receive function which emits an event Received
Contract A is R
- Has constructor
  1. Deploys NFToken
  2. Mints token id=1
  3. Transfers token id=1 to self
Contract B
- Has constructor
  1. Deploys NFToken
  2. Deploys R
  3. Transfers token id=1 to R

Tests:

Test 1
1. Transaction 1 -- Deploy NFToken
2. Transaction 2 -- Mint token id=1
3. Transaction 3 -- Deploy Contract R
4. Transaction 4 -- Transfer token id=1 to R
5. Expect NO event on Constantinople
Test 2
1. Transaction 1 -- Deploy NFToken
2. Transaction 2 -- Mint token id=1
3. Transaction 3 -- Deploy Contract R
4. Expect NO event on Constantinople
Test 3
1. Transaction 1 -- Deploy Contract B
2. Expect event on Constantinople (but no event with same test using old version of implementation)

Kristijan Sedlak · Answer 1 · Fri Dec 20 2019 19:51:54 GMT+0800 (China Standard Time)

@fulldecent do you have time to add these? The rest of the team is overbooked at the moment.

William Entriken · Answer 2 · Sun Dec 22 2019 10:16:23 GMT+0800 (China Standard Time)

You bet, I'm on it.

Francisco · Answer 3 · Tue Feb 04 2020 03:35:02 GMT+0800 (China Standard Time)

I think there should be another test for a transfer to a contract that has selfdestructed, since the result of extcodehash will be different.

William Entriken · Answer 4 · Fri Feb 07 2020 05:37:26 GMT+0800 (China Standard Time)

Progress on a test is here #241

Requesting help with this line:

I need to check logs from a deploy transaction.