nibbstack / erc721

The reference implementation of the ERC-721 non-fungible token standard.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

isContract is incorrect

fulldecent opened this issue · comments

Technically, the documentation at https://github.com/0xcert/ethereum-erc721/blob/master/src/contracts/utils/address-utils.sol is incorrect. Specifically, a contract that is constructing will return 0 until it is completing construction.

This does not affect us much, but somebody using just that code will get unexpected results, so this is a security issue.

References: