Review 0.5.1 external/public change
fulldecent opened this issue · comments
Now it is no longer necessary change from external to public. Our code should be updated.
Also, the EIP-721 should be updated, as forewarned by the text in ERC-721. Others changes are coming to Solidity and so further changes will be made to ERC-721, again as has been specified in 721.
I'm not completely sure to what you are referring to. If it is to solidity 0.5.0 update that states: Interfaces: Allow overriding external functions in interfaces with public in an implementing contract. Then there are no changes to our code since we use external everywhere.
Sorry. Please ignore. I'm crazy and/or lost this reference.