niXman / yas

Yet Another Serialization

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The the latest commit which is a PR from askamn/master has broken the bug fix about #93

mrbeardad opened this issue · comments

When I switch to this commit 627d9e8 and it gives me right json format.

But the latest commit 45a9855 that Merge pull request #91 from askamn/master gives incorrect json format.

So, the the latest commit 45a9855 has broken the bug fix about #93 and 627d9e8

it seems that we do not understand each other...

you wrote: When I switch to this commit 627d9e8 and it gives me right json format.
ok!

next: But the latest commit 45a9855 that Merge pull request #91 from askamn/master gives incorrect json format.
but that commit doesn't make any changes to the file that is the serialization for map: look at diff: 45a9855

furthermore, the current master branch contains the correct version (https://github.com/niXman/yas/blob/master/include/yas/types/concepts/keyval.hpp) that uses array ([, ]) for maps.
or is it wrong JSON?

emmmm.... I have found the reason. That file is different from mine in my local repository, although the hash code of the latest commit in my local repository is same to the remote repository. I've removed and clone it again, and fixed this problem. Maybe it is a bug about git or github?

I shouldn't waste time explaining to you how git works, figure it out yourself.