FetchArrayMeasurementRequest does not accept meas_wfm_size parameter

Question

FetchArrayMeasurementRequest does not accept meas_wfm_size parameter

ni-jfitzger opened this issue a year ago · comments

FetchArrayMeasurementRequest does not accept the meas_wfm_size parameter defined in the API. Instead, all samples are returned by FetchArrayMeasurementResponse.

AB#2364316

Jay Fitzgerald · Answer 1 · Fri Apr 14 2023 03:20:42 GMT+0800 (China Standard Time)

This is already fixed. @bkeryan @reckenro if you feel any important details should be added, please do so. This issue was created so that nimi-python could reference it.

Brad Keryan · Answer 2 · Fri Apr 14 2023 03:33:06 GMT+0800 (China Standard Time)

I think the PR description covers the important details:

Mark the new meas_wfm_size as optional in the proto request.

Updates custom service handler to

If the request's meas_wfm_size was set to a non-negative value, use it.

If it wasn't set or if it was set to a negative number, get the size using ActualMeasWfmSize.
This makes it a backwards compatible change and provides the option for a 0-fetch request.