Wrong file name when downloading file, always getting 'document' as file name

Question

Wrong file name when downloading file, always getting 'document' as file name

alveshelio opened this issue 2 years ago · comments

I'm uploading a file my-filename.pdf with

const { fileMetadata, error: uploadError } = await storage.upload({
  file,
  name: file.name,
  bucketId: `myBucket`,
})

And then I'm retrieving the file as follow:

const getFileUrl = async (): Promise<void> => {
  const { presignedUrl, error } = await storage.getPresignedUrl({
    fileId: data?.profile?.file?.id,
  })

  if (!error) {
    window.open(presignedUrl?.url, '_blank')?.focus()
  }
}

When opening the file in a new window and downloading the file, the name of the file is always document.fileExtension. I'd expect the file name to be used instead of document

David Barroso · Answer 1 · Fri Apr 15 2022 03:44:43 GMT+0800 (China Standard Time)

Which version of hasura-storage are you running?

Helio Alves · Answer 2 · Fri Apr 15 2022 05:19:37 GMT+0800 (China Standard Time)

I have "@nhost/nextjs": "^1.0.11" and "@nhost/react": "^0.5.1",

Helio Alves · Answer 3 · Mon Apr 18 2022 23:15:55 GMT+0800 (China Standard Time)

@dbarrosop Is this the info you where asking for?

David Barroso · Answer 4 · Tue Apr 19 2022 01:11:12 GMT+0800 (China Standard Time)

no, not exactly, I was wondering about the server itself. If you are running it in your dev machine you can probably check the container image with docker ps. If you are consuming it via nhost's cloud you can reach out to me via discord and I can check it for you.

Helio Alves · Answer 5 · Tue Apr 19 2022 20:31:08 GMT+0800 (China Standard Time)

So I'm using
nhost/hasura-storage:sha-623f285 and minio/minio:RELEASE.2021-09-24T00-24-24Z

David Barroso · Answer 6 · Thu Apr 21 2022 19:44:31 GMT+0800 (China Standard Time)

Ok, thanks. Are you using the nhost cli? If yes, we are releasing a new version of the cli that will update hasura-storage later today so I will ask you to test after that as I couldn't reproduce the issue with that version. If you are running it somehow else let me know and I can provide you with instructions to update hasura-storage.

David Barroso · Answer 7 · Fri Apr 22 2022 22:39:19 GMT+0800 (China Standard Time)

Would you mind testing using the latest nhost cli? https://github.com/nhost/cli/releases/tag/v0.6.6

Helio Alves · Answer 8 · Sun Apr 24 2022 08:53:19 GMT+0800 (China Standard Time)

Hi @dbarrosop,

After upgrading to V.06.6 I can confirm that the problem is solved.

Thank you

Helio Alves · Answer 9 · Wed May 04 2022 01:58:05 GMT+0800 (China Standard Time)

Hi @dbarrosop,

I'd like to know if this has been pushed to production. In local I have Nhost CLI version v0.6.8 and I'm running I have nhost/hasura-storage:0.1.5 and minio/minio:RELEASE.2021-09-24T00-24-24Z.

Even though in local I now have the correct file name, in production I'm still getting document as file name.

Thanks.

David Barroso · Answer 10 · Wed May 04 2022 16:19:23 GMT+0800 (China Standard Time)

It's been done for most applications but we held off for some "old" users of hasura-storage. If you ping me on discord or let me know your subdomain I can make sure your application is up to date.

David Barroso · Answer 11 · Wed May 04 2022 22:59:04 GMT+0800 (China Standard Time)

We just decided to upgrade the remaining apps so yours should be too. Let me know if it is working now. Thanks!

David Barroso · Answer 12 · Thu May 19 2022 22:18:09 GMT+0800 (China Standard Time)

I am closing this one as I think everything should be fine, otherwise, feel free to reopen.

Thanks!