ngxtension / ngxtension-platform

Utilities for Angular

Home Page:https://ngxtension.netlify.app/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

injectQueryParams (key) has incorrect type

james-schwartzkopf opened this issue · comments

injectQueryParams(key) says it returns Signal<string | null> but could also return an array of strings.

I would suggest changing the current version to return the first string in the array if it's an array. That would keep it compatible with what people are expecting, Maybe add an optional flag that would force it to an array if it's a single string. Similar to getAll on ParamMap.

This should be solved by #232

Can you confirm if it's fixed?

I think this can also be closed! @eneajaho