File view is slow (slower than same file's blame view)
GoogleCodeExporter opened this issue · comments
What steps will reproduce the problem?
1. Load
https://chromium.googlesource.com/chromium/src/+/master/build/common.gypi
2. Load
https://chromium.googlesource.com/chromium/src/+blame/master/build/common.gypi
What is the expected output? What do you see instead?
1 should be no slower than 2. 1 is slower than 2.
Original issue reported on code.google.com by cjhopman@chromium.org on 18 Jun 2014 at 11:32
Original comment by dborowitz@google.com on 18 Jun 2014 at 11:33
- Changed state: Duplicate
log view and file view are different, but ok...
Also, note that the blame view contains everything shown in the file view
(which is not the case for log view).
Original comment by cjhopman@chromium.org on 18 Jun 2014 at 11:37
Misread your URLs, sorry. I can't reproduce the slowness with (1) though. There
are various layers of caching involved, maybe you got unlucky?
Original comment by dborowitz@google.com on 18 Jun 2014 at 11:52
- Changed state: New
Slower to me as well (i.e. the bug looks valid from here).
Original comment by b.kelemen@samsung.com on 19 Jun 2014 at 2:21
Dave, are logs kept showing the performance of each request? Can you verify
whether Chris's request in (1) was slower than (2)? As for which layer of
caching is involved, is there enough data in the log to show why he may have
been unlucky?
Original comment by cmp@chromium.org on 19 Jun 2014 at 11:08
Erk, in issue 56, issue 57 was merged as duplicate. However, the view of issue
57 is still "New" and mergedinto is blank.
Original comment by cmp@chromium.org on 19 Jun 2014 at 11:13