ngneat / loadoff

🤯 When it comes to loaders, take a load off your mind...

Home Page:https://netbasal.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Feature request: Keep value

Waterstraal opened this issue · comments

commented

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

The value is discarded on a new emission. This is not always the desired behavior, for example when you want to implement reload functionality where you want to keep showing the current items while you fetch fresh items in the background.

Expected behavior

The value is persisted.

Minimal reproduction of the problem with instructions

I created a stackblitz with a workaround for above problem:
https://stackblitz.com/edit/loadoff-keep-value-on-reload?file=src%2Fapp%2Fhello.component.ts

What is the motivation / use case for changing the behavior?

I feel like it's a common use case and it would be nice if the library would support it out of the box.

Do u want to submit a PR?

commented

@NetanelBasal I have created a PR