ngneat / input-mask

🎭 @ngneat/input-mask is an angular library that creates an input mask

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update Inputmask library

bogusweb opened this issue Β· comments

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

How i can create pull request with update Inptumask dependency for both versions?

@bogusweb what is the issue?

@shhdharmen i dont know how to create pull request which update library version for both versions this packages (like for angular 13+ and angular <13). Which branch is responsible for which version of this library?

New version Inputmask library fix few issues like #38

You can first create a PR for Angular 13+, for that create branch from main and raise a PR to beta.

ok thanks, i just created a PR to main branch but i didnt see a beta branch which contain older angular version.

And sorry, i should create just a discussion topic not issue :<

@shhdharmen thx for merge, now i have a question. Whether this change will also be introduced in the 4.x version for <13?

@bogusweb I had to revert the commit, because commit message was not as per semver. Could you please create a PR again to beta branch? This time when you run npm run commit, select feat. Sorry for the rework.

And for Angular <13, create PR to 4.x.x branch.

Ref: https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api

πŸŽ‰ This issue has been resolved in version 5.1.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€