ngneat / falso

All the Fake Data for All Your Real Needs 🙂

Home Page:https://ngneat.github.io/falso/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Why can toCollection return a non-array?

dmitriybo opened this issue · comments

Description

In my opinion, the toCollection method should always return an array (if it does not passed length, then length = 1). The reason for this is very simple: toCollection is used to generate an array of elements. If for some reason you think otherwise, then at least make the correct typing. Currently toCollection always returns the type Collection | Collection[], but should return Collection[] if length is passed.

image

The example in the specification also needs to be improved:

image

Proposed solution

No response

Alternatives considered

No response

Do you want to create a pull request?

No

Came to post this same suggestion +1. toCollection to always return an array.

Suggestion Solution
toCollection() returns array with default length of 3

Is anyone working on this? seems like a simple fix, I don't mind taking it on, just set the type to return array only right? I think it's ok to return an array of 1 by default even, what's the point of using this function to return just an object??