ngneat / falso

All the Fake Data for All Your Real Needs 🙂

Home Page:https://ngneat.github.io/falso/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Multiple phone numbers from `randPhoneNumber()`

matt0089 opened this issue · comments

Is this a regression?

No

Description

When making multiple calls of falso.randPhoneNumber(), sometimes it returns multiple phone numbers

E.g.

> falso.randPhoneNumber()
'+232 76 131814'
> falso.randPhoneNumber()
'+672 156 512'
> falso.randPhoneNumber()
'+850 191 997 0805'
> falso.randPhoneNumber()
'+975 17 322 723, +975 6 166 883'
...

It looks like just some simple typos forgetting quotes. Here's an example:
https://github.com/ngneat/falso/blob/main/packages/falso/src/lib/phone-number.json#L120

I can make a PR soon if you want.

Thank you for this package, it's been great so far. In particular, the rand() function is really convenient and intuitive.

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in

node v14

Anything else?

No response

Do you want to create a pull request?

Yes

You're welcome to create a PR, thanks.

I am able to work on this.

Thank you guys! Sorry I missed coming back to this