ng-packagr / ng-packagr

Compile and package Angular libraries in Angular Package Format (APF)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

secondary entry point peer deps

LPCmedia opened this issue · comments

Type of Issue

[X] Bug Report
[X] Feature Request

Description

We are trying to figure out how to ship part of a library that requires a peerDep. When specifying peer deps in a secondary entry point, they are removed from the package.json that is output by the build.

How To Reproduce

Create a library.
Create a secondary entry point which depends on an external lib. In our case: monaco-editor.
Add package.json to the entry point:

{
    "name": "@foo/ngx-components/editor",
    "version": "1.0.0",
    "peerDependencies": {
        "angular/core": "^12.0.0",
        "monaco-editor": "0.45.0"
    },
    "ngPackage": {
        "lib": {
            "entryFile": "src/index.ts"
        }
    }
}

Expected Behaviour

We build the lib and the peer deps are in the entry point's package json.

instead we get:

{
  "module": "../fesm2022/foo-ngx-components-editor.mjs"
}

Version Information

$ node_modules/.bin/ng-packagr --version
ng-packagr:            17.1.2
@angular/compiler:     17.1.1
typescript:            5.3.3
node: v18.16.0
npm/yarn: 1.22.4

Thank you for quick response and clarification.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

This action has been performed automatically by a bot.