Show "browser not supported" modal only once per session
corneliusroemer opened this issue · comments
Some people may not be able to use Nextclade Web on a supported (and tested) browser, as that list excludes various Chinese browser and Safari, which might be the only browsers available to some users.
On master, we show the "browser not supported" modal whenever the user changes page, even if the user has previously dismissed the modal with "I want to try anyways".
It would be good to show the warning only once per session.
How to reproduce? Set the user agent to an unsupported browser, e.g. Safari.
@corneliusroemer How do you define a session?
Good question, I'd say just store the cookie dismissal in local storage or cookies?
I've just realized that the banner that shows when you go to "master.clades.nextstrain.org", the one that says "this is a preview version" only shows once when I navigate to the site. I think making the browser warning show with the same dismissal period would be good.
Does this answer the question "how do you define a session" @ivan-aksamentov?